[Raw Msg Headers][Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: SBL blocklist query trouble

On Tue, Nov 04, 2003 at 03:19:44AM -0600, Roy Bixler wrote:
> Here's some debug output that illustrates the problem:
> 000- Alias-recursion: 4
> 000- Key: 8/TAG/'_rbl0'
> 000-   Attribute:
> -126/test-dns-rbl/'relays.ordb.org.:l1.spews.dnsbl.sorbs.net.:http.dnsbl
> .sorbs.net.:socks.dnsbl.sorbs.net.:misc.dnsbl.sorbs.net.:sbl.spamhaus.or
> g.'000-     accepted!000-   Attribute: 0/??/''000-     not interested,
> skipped...000-   Attribute: 0/??/''
> 000-     not interested, skipped...
> 000-   Attribute: 0/??/''
> <continues until killed -- infinite loop>

Aargh...    The data is treated as SIGNED CHAR, which means the length 
field is considered here NEGATIVE when the attribute is sufficiently 
long...  Me stupid, ....

Sprinkling around couple "unsigned"s into the code solves that.
I added (just in case) couple other tests, too.

> Here's a patch which seems to fix the symptom:
> Of course, I'm sure it would be better to find out how the attribute
> is getting set wrong and fix that.

The attribute was just fine.  Its interpretation wasn't...

> -- 
> Roy Bixler <rcb@ucp.uchicago.edu>
> The University of Chicago Press

/Matti Aarnio	<mea@nic.funet.fi>
  (still innundated with large backlog of things..)
To unsubscribe from this list: send the line "unsubscribe zmailer" in
the body of a message to majordomo@nic.funet.fi