[Raw Msg Headers][Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: transport.c patch



> Greetings,
> 
> 	That would cause scheduler to dump core, and actually on
> any *BSD system it is very inappropriate to do any string operation
> with a NULL operand. We should browse through the sources for things
> like this.

	Nope,  replhost is constant string defined in  scheduler/conf.c.
	I doubt it ever can become NULL.  Additional debugging suggested.

/Matti Aarnio <mea@nic.funet.fi>

> RCS file: transport.c,v
> retrieving revision 1.1
> diff -c -r1.1 transport.c
> *** transport.c 1997/07/22 14:23:23     1.1
> --- transport.c 1997/07/22 14:23:39
> ***************
> *** 292,298 ****
>          */
>         os = buf;
>         for (i = 0; vhead->thgrp->ce.argv[i] != NULL; ++i) {
> !         if (strcmp(vhead->thgrp->ce.argv[i], replhost) == 0) {
>             av[i] = howp->name;
>           } else if (strcmp(vhead->thgrp->ce.argv[i], replchannel) == 0) {
>             av[i] = chwp->name;
> --- 292,298 ----
>          */
>         os = buf;
>         for (i = 0; vhead->thgrp->ce.argv[i] != NULL; ++i) {
> !         if (replhost != NULL && strcmp(vhead->thgrp->ce.argv[i], replhost) == 0) {
>             av[i] = howp->name;
>           } else if (strcmp(vhead->thgrp->ce.argv[i], replchannel) == 0) {
>             av[i] = chwp->name;
> 
> -- 
> 	How can a flower so beautiful, be so laiden down with dew
>