Re: Router dump core on invalid messages

[Matti Aarnio <mea@nic.funet.fi>]

> Hi!
> Some people in my department are also debugging mail so my zmailer
> has received some messages with invalid structure (lack of To: line
> or double From: lines + empty line between header lines).

	"To:" contents is irrelevant when the message comes via
	SMTP -- the transport envelope says what it is.

	When there is an empty line after a header, the rest of
	the message is known as "body".  In the sample case a copy
	of headers is included into the body by some earlier feeder.
	(The router does not touch on the message body, transporters
	 may touch, but that is another story.)

> I understand that in such case router can complain or just route the
> message to postmaster but unfortunately it dumps core :(
> If anybody is interested in deeper investigations I attach information
> from gdb together with offending files (just taken from the router queue).
> I hope this can help to catch one more bug in my favorite MTA :-)
> 	Jurek
> ------------------------------------------------------------------------
> Jerzy Sobczyk              ____________ ___     Institute of Control and
> J.Sobczyk@ia.pw.edu.pl    /  /     |  |/  _\    Computation Engineering, 
>                          /  /  /|  |  |  (____         Warsaw University 
> tel.+48 2 660 7297      /  /  _>|  |  |\____  \            of Technology
> fax.+48 22 253719      /__/__/__|__|__|_____)  \       Nowowiejska 15/19
> tlx. 813 307 pw pl    /________________________/   00-665 Warsaw, POLAND 
> ------------------------------------------------------------------------
> 
> ------------------ Invalid message 1 -----------------------------------
....
> external
> rcvdfrom ipedsp1.ipe.pw.edu.pl ([148.81.29.102])
> with ESMTP
> authinfo UNKNOWN@ipedsp1.ipe.pw.edu.pl (port 1099)
> from <kwisnie@ipedsp1.ipe.pw.edu.pl>
> to <kwisniew@neutron.elka.pw.edu.pl>
> Received: by ipedsp1.ipe.pw.edu.pl
>         (1.37.109.11/16.2) id AA116859566; Thu, 15 Dec 1994 14:52:46 +0100
> Date: Thu, 15 Dec 1994 14:52:46 +0100
> From: Krzysztof Wisniewski <kwisnie@ipedsp1.ipe.pw.edu.pl>
> Message-Id: <199412151352.AA116859566@ipedsp1.ipe.pw.edu.pl>
> Apparently-To: kwisniew@neutron.elka.pw.edu.pl

	If   kwisniew  has local  .forward, 2.97 could have caused some
	problems, though that is more like a feeling, than fact...
	Other than that I see no problems -- not even when I tested these
	files of yours with 2.99.3/4..

	The rest of that message contained original headers
	and the message body.

> >From owner-stasz1lo@PLEARN.EDU.PL Thu Dec 15 13:10 MEZ 1994 forwarded by kwisnie
> Received: from plearn.edu.pl by ipedsp1.ipe.pw.edu.pl with SMTP
>         (1.37.109.11/16.2) id AA109493388; Thu, 15 Dec 1994 13:09:48 +0100
> Return-Path: <owner-stasz1lo@PLEARN.EDU.PL>
> Message-Id: <199412151209.AA109493388@ipedsp1.ipe.pw.edu.pl>
> Received: from PLEARN.EDU.PL by plearn.edu.pl (IBM VM SMTP V2R1)
>    with BSMTP id 2835; Thu, 15 Dec 94 13:09:17 CET
> Received: from PLEARN.EDU.PL (NJE origin LISTSERV@PLEARN) by PLEARN.EDU.PL (LMail V1.2a/1.8a)
> with BSMTP id 7730; Thu, 15 Dec 1994 13:09:17 +0200
> Date:         Thu, 15 Dec 1994 13:06:13 CET
> Reply-To: "DISCUSSION LIST OF STANISLAW STASZIC HIGH SCHOOL, LUBLIN,
>               POLAND STASZ1LO" <STASZ1LO@PLEARN.BITNET>
> Sender: "DISCUSSION LIST OF STANISLAW STASZIC HIGH SCHOOL, LUBLIN,
>               POLAND STASZ1LO" <STASZ1LO@PLEARN.BITNET>
> From: Adam Jamroz <JAME%PLEARN.BITNET@PLEARN.EDU.PL>
> Subject:      sylwester
> To: Multiple recipients of list STASZ1LO <STASZ1LO@PLEARN.BITNET>
> 
> xxxxx xxxxxxx xxxxxxxxxx xxx xxxxxxx x xxxxxx xxxxxxxx xxxxxx xx xxxxxx
> xxx xxx xxxxxx xxxxx xxxxxxxx xxx xxxx xx xxxxx xx xxxx xxxxxx
> xxxxx xxxxxxxxxxx xxxxxxxxx xx xxx xxxxxx xxxxxx xxxxxxx xx xx xxxxx xxxxx
> x xxxx xxxxxx xxxxxxx xxxxx xxxxxx xxxxx x xxxxxxx xxxxx xxxxxx xxxx xxxxxx
> x xxxxxxxx xxxxxxxx
>                        xxxx
> ------------------ Invalid message 2 -----------------------------------
> proton<jurek>(193)# gdb /export/local/mail/bin/router router/core
> Core was generated by `/export/local/mail/bin/router -dkn2'.
> Program terminated with signal 11, Segmentation fault.
> #0  0x226f0 in sequencer (e=0x6e7a8, file=0x87e6c "56823-2") at rfc822.c:1264
> 1264                    QATTRIBUTES(e->e_from_trusted) =QATTRIBUTES(e->e_from_resolved);
> (gdb) where

	This (like the previous one) gives a feeling of junk on
	e->e_from_resolved -envelope, but it is so many patches
	ago that I am not sure what it was about  (too many changes
	since then..)


....
> external
> rcvdfrom ipedsp1.ipe.pw.edu.pl ([148.81.29.102])
> with ESMTP
> authinfo UNKNOWN@ipedsp1.ipe.pw.edu.pl (port 1097)
> from <kwisnie@ipedsp1.ipe.pw.edu.pl>
> to <kwisniew@neutron.elka.pw.edu.pl>
> Received: by ipedsp1.ipe.pw.edu.pl
>         (1.37.109.11/16.2) id AA116929708; Thu, 15 Dec 1994 14:55:08 +0100
> Date: Thu, 15 Dec 1994 14:55:08 +0100
> From: Krzysztof Wisniewski <kwisnie@ipedsp1.ipe.pw.edu.pl>
> Message-Id: <199412151355.AA116929708@ipedsp1.ipe.pw.edu.pl>
> Apparently-To: kwisniew@neutron.elka.pw.edu.pl

	Also this syntax is all fine.

	If 2.99.4 does it too, problem is on routing
	configurations somewhere.

		/Matti Aarnio	<mea@nic.funet.fi>