[Raw Msg Headers][Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Patch for empty lines in smtpserver log



Hi I've found that sometimes the function type() is called with \n,
so it writes \n\n to the smtpserver log.

I've made a little cleanup on that

Here is the patch



==========================================================
diff -u -r1.1.1.1 -r1.2
--- smtpserver/mxverify.c	23 Jan 2007 12:34:20 -0000	1.1.1.1
+++ smtpserver/mxverify.c	22 Nov 2007 23:36:57 -0000	1.2
@@ -948,7 +948,7 @@
 		    *s = ' ';
 		}
 	      }
-	      type(NULL,0,NULL,"Found DNS TXT object: %s\n",
+	      type(NULL,0,NULL,"Found DNS TXT object: %s",
 		   (*msgp ? *msgp : "<nil>"));
 	    }
 	    return -1;
diff -u -r1.4 -r1.5
--- smtpserver/smtpcmds.c	9 Oct 2007 17:49:51 -0000	1.4
+++ smtpserver/smtpcmds.c	22 Nov 2007 23:36:57 -0000	1.5
@@ -840,7 +840,7 @@
 	    if ((neg & DELIVERBY_R) &&
 		OCP->deliverby_ok > 0 && val < OCP->deliverby_ok) {
 	      smtp_tarpit(SS);
-	      type(SS, 553, m571, "Too small short delivery deadline value
given: %d\n", val);
+	      type(SS, 553, m571, "Too small short delivery deadline value
given: %d", val);
 	      rc = 1;
 	      break;
 	    }
diff -u -r1.2 -r1.3
--- smtpserver/smtpserver.c	22 Mar 2007 12:52:56 -0000	1.2
+++ smtpserver/smtpserver.c	22 Nov 2007 23:36:57 -0000	1.3
@@ -2091,7 +2091,7 @@
         fflush(logfp);
     }
     if (logfp) {
-	type(NULL,0,NULL,"aborted (%ld bytes): %s\n", tell, msg);
+	type(NULL,0,NULL,"aborted (%ld bytes): %s", tell, msg);
 	fflush(logfp);
     }
 
==========================================================



Saludos
Leonardo Helman
Pert Consultores
Argentina


diff -u -r1.1.1.1 -r1.2
--- smtpserver/mxverify.c	23 Jan 2007 12:34:20 -0000	1.1.1.1
+++ smtpserver/mxverify.c	22 Nov 2007 23:36:57 -0000	1.2
@@ -948,7 +948,7 @@
 		    *s = ' ';
 		}
 	      }
-	      type(NULL,0,NULL,"Found DNS TXT object: %s\n",
+	      type(NULL,0,NULL,"Found DNS TXT object: %s",
 		   (*msgp ? *msgp : "<nil>"));
 	    }
 	    return -1;
diff -u -r1.4 -r1.5
--- smtpserver/smtpcmds.c	9 Oct 2007 17:49:51 -0000	1.4
+++ smtpserver/smtpcmds.c	22 Nov 2007 23:36:57 -0000	1.5
@@ -840,7 +840,7 @@
 	    if ((neg & DELIVERBY_R) &&
 		OCP->deliverby_ok > 0 && val < OCP->deliverby_ok) {
 	      smtp_tarpit(SS);
-	      type(SS, 553, m571, "Too small short delivery deadline value given: %d\n", val);
+	      type(SS, 553, m571, "Too small short delivery deadline value given: %d", val);
 	      rc = 1;
 	      break;
 	    }
diff -u -r1.2 -r1.3
--- smtpserver/smtpserver.c	22 Mar 2007 12:52:56 -0000	1.2
+++ smtpserver/smtpserver.c	22 Nov 2007 23:36:57 -0000	1.3
@@ -2091,7 +2091,7 @@
         fflush(logfp);
     }
     if (logfp) {
-	type(NULL,0,NULL,"aborted (%ld bytes): %s\n", tell, msg);
+	type(NULL,0,NULL,"aborted (%ld bytes): %s", tell, msg);
 	fflush(logfp);
     }