Re: wrong install in proto/Makefile

[Matti Aarnio <mea@nic.funet.fi>]

On Fri, Apr 14, 2000 at 11:03:15AM +0400, Eugene Crosser wrote:
> In proto/Makefile{,.in} there is a context:
...
> If $INSTALL was configure'd as ".././install-sh" (gnu install not found)
> then from within .../db it is not accessibe.  I'd suggest to change this
> like:
> 
>         for x in db/aliases db/fqdnaliases db/dbases.conf db/localnames \
>                  db/routes db/smtp-policy.* db/kill-headers ;   \
>         do              \
>                 $(INSTALL) -m 644 $$x $$MAILVAR/db/proto/$$x ; \
>         done ; )

  Not good.  That assumes the compilation and installation is happening
  "in place", never in adjacent directory.  This is better:

-       cd $(srcdir)/db; \
-       for x in aliases fqdnaliases dbases.conf localnames routes \
-                smtp-policy.* kill-headers ;   \
+       P=$(srcdir)/db; \
+       for x in $$P/aliases $$P/fqdnaliases $$P/dbases.conf $$P/localnames \
+                $$P/routes $$P/smtp-policy.* $$P/kill-headers ;        \

  I think I am right, am I not ?

  It makes testing simpler when you have (like I do now) a set of adjacent
  directories each with different configuration.
  There I just "make clean;make", and see what breaks in compilation.

> Eugene

-- 
/Matti Aarnio	<mea@nic.funet.fi>