Re: problems compiling 2.99.42 (Linux)

[Matti Aarnio <mea@nic.funet.fi>]

> On Sun, 24 Nov 1996, Simon Karpen wrote:
> 
> > (in transports/hold/hold.c)
> > hold.c: in function hold_ns
> > hold.c:485:too few arguments to function getrrtype
> 
> Just change line 485 in hold.c to (adding 'verboselog' as the last param):
> 
>         switch (getrrtype(host, sizeof host, qtp->value, 2, verboselog)) {
> 
> This minor error also cropped up in Solaris 2.5 on a SPARC4, but the above
> fixes it, and the whole thing compiled without error :-)

	Well, not quite -- it works, but I inteded something else..

	I wrestled to get rid of several not-so-easily visible magic
	variables used all around (as a side-effort on localizing
	information of SMTP-client):

----------------------------------------------------------------
--- transports/hold/hold.c~	Fri Oct 25 22:39:30 1996
+++ transports/hold/hold.c	Mon Nov 25 12:08:30 1996
@@ -136,8 +136,6 @@
 #define	putc	fputc
 #endif	/* lint */
 
-FILE *verboselog = NULL; /* getrr() needs this .. */
-
 int
 main(argc, argv)
 	int argc;
@@ -482,7 +480,7 @@
 	  return 1;		/* inconsistency with search_res.c, yell! */
 	}
 	strcpy(host, s);
-	switch (getrrtype(host, sizeof host, qtp->value, 2)) {
+	switch (getrrtype(host, sizeof host, qtp->value, 2, NULL)) {
 	case 0:
 		return 1;	/* negative reply */
 	case 1:
----------------------------------------------------------------


> Cheers,
> --
> James S. MacKinnon           Office: P-139 Avahd-Bhatia Physics Lab
> University of Alberta        email : Jim.MacKinnon@Phys.UAlberta.CA