[Raw Msg Headers][Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch for peer review

To: "Darryl L. Miles" <darryl@netbauds.net>
Subject: Re: Patch for peer review
From: Eugene Crosser <crosser@rol.ru>
Date: Thu, 03 Mar 2005 12:13:02 +0300
CC: zmailer@nic.funet.fi
In-Reply-To: <42266585.9070707@netbauds.net>
Original-Recipient: rfc822;zmailer-log@nic.funet.fi
References: <42266585.9070707@netbauds.net>
Sender: zmailer-owner@nic.funet.fi
User-Agent: Mozilla Thunderbird 1.0 (X11/20041206)

Darryl L. Miles wrote:

> policytest.c: From looking over the SPF2 API I think there is a missing 
> SPF_free_c_results() needed in a minor error condition.  Also in looking 
> at the #warning the spf_localpolicy is set from cfgread.c.  It was 
> possible for smtpserver.conf to not have any spf-localpolicy 
> configuration directive in smtpserver.conf but initialize_spf() to be 
> called (due to SPF + in policy file) in this situation an unsafe 
> free(NULL) may result.  I can't see any reason why we should worry about 
> releasing this piece memory so just removing the lines seems fine to me.

SPF related part looks OK for me from the first glance; I did not really 
check it though...

Eugene

OpenPGP digital signature

References:
- Patch for peer review
  - From: "Darryl L. Miles" <darryl@netbauds.net>

Prev by Date: smtp TA over SSL not handling shutdown
Next by Date: Re: smtp TA over SSL not handling shutdown
Prev by thread: Patch for peer review
Next by thread: smtp TA over SSL not handling shutdown
Index(es):
- Date
- Thread