[Raw Msg Headers][Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: zpwmatch.c bug?



On 07-Sep-99 at 18:13, Matti Aarnio (mea@nic.funet.fi) wrote:
> On Tue, Sep 07, 1999 at 01:55:16PM +0400, Eugene Crosser wrote:
> > I guess that line 217 in zpwmatch.c should read
> >   return ok ? NULL : "Authentication Failed";
> > and not 
> >   return (strcmp(cr, spw->sp_pwdp) == 0) ? NULL : "Authentication
> >   Failed"; 
> > like now...
> 
>   Oops...  What I have been thinking, when I did forget that ???

There are a few more "return 0"-s in this file...  And a "return 0"
after failing getspent() which is probably a *bad* idea.

Eugene